Lizandro GuarnizoandClaude Opus 5
8631e6f729
Root cause behind most "stuck loading" reports: the backend changed shape (schedules became an array, location_preferences a string) while the mobile parser still hard-cast to Map/int. The TypeError was swallowed by a silent catch that returned null, and screens only handled the success state, so a parse failure rendered as a permanent spinner. Same class of bug appeared across service lists via non-null map lookups and a total absence of request timeouts. Ported from prosappweb: - in-app suggestions (POST /suggestions) - policies/terms from GET /settings/policies - configurable appointment length (slot_duration_minutes) - block/unblock calendar slots (POST /services/block) - GPS city detection on the profile (Nominatim) - server-side professional search with haversine distance - retry cooldown after a rejected professional application Reliability: - parse schedules array (day_of_week 0=Mon) and string location_preferences - read times as wall clock, so 08:00 stays 08:00 across timezones - carry minutes into hours in TimeOfDay.add; a minute-based step used to loop forever and freeze the calendar (covered by test/time_slots_test.dart) - semver update check instead of string equality, which blocked every build that did not exactly match the configured version - request timeouts across all repositories - surface HTTP >= 400 instead of reporting failed writes as success - error states with retry instead of an indefinite shimmer Includes pre-existing uncommitted work from the UI redesign. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
49 lines
1.7 KiB
Dart
49 lines
1.7 KiB
Dart
/// Compares dotted numeric versions, e.g. "1.0.14" vs "1.0.2".
|
|
///
|
|
/// Returns a negative number when [a] is older than [b], 0 when they are
|
|
/// equivalent, and a positive number when [a] is newer. Missing segments count
|
|
/// as 0, so "1.0" and "1.0.0" are equivalent. Returns null when either side
|
|
/// cannot be parsed.
|
|
int? compareVersions(String? a, String? b) {
|
|
final left = _segments(a);
|
|
final right = _segments(b);
|
|
if (left == null || right == null) return null;
|
|
|
|
final length = left.length > right.length ? left.length : right.length;
|
|
for (var i = 0; i < length; i++) {
|
|
final l = i < left.length ? left[i] : 0;
|
|
final r = i < right.length ? right[i] : 0;
|
|
if (l != r) return l - r;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
/// Whether [current] is strictly older than [minimum].
|
|
///
|
|
/// Deliberately fails open: a missing or unparseable value returns false, so a
|
|
/// backend misconfiguration can never lock users out of the app behind the
|
|
/// blocking "you must update" dialog. Equal or newer versions are fine too — a
|
|
/// build ahead of the configured minimum is not out of date.
|
|
bool isUpdateRequired(String? current, String? minimum) {
|
|
final result = compareVersions(current, minimum);
|
|
if (result == null) return false;
|
|
return result < 0;
|
|
}
|
|
|
|
List<int>? _segments(String? version) {
|
|
if (version == null) return null;
|
|
final trimmed = version.trim();
|
|
if (trimmed.isEmpty) return null;
|
|
|
|
// Tolerate build suffixes such as "1.0.14+14" or "1.0.14-beta".
|
|
final core = trimmed.split(RegExp(r'[+\-]')).first;
|
|
final parts = core.split('.');
|
|
final segments = <int>[];
|
|
for (final part in parts) {
|
|
final value = int.tryParse(part.trim());
|
|
if (value == null) return null;
|
|
segments.add(value);
|
|
}
|
|
return segments.isEmpty ? null : segments;
|
|
}
|