fix: repair the booking flow end to end
Verified the real contracts against the backend before changing anything.
Chat (three defects, one root cause):
- every chat endpoint is keyed by the chat id, not the service id. The app
called POST /chat/start, threw away the id it returned and kept using the
service id, so every later request 404'd.
- messages arrive as {data, meta}; reading the body as a bare list threw and
surfaced as an empty conversation.
- the bloc created the chat and then never emitted ChatLoaded (the else hung
off `if (chat == null)`), leaving a permanent spinner. Sending a message
emitted nothing at all, so it vanished until reopening.
Messages now render optimistically and roll back if the send fails, and the
screen distinguishes "loading" from "could not open" with a retry.
Appointments:
- a null range1_hour2 parsed as 00:00, so new appointments were born
"Caducado" and every action was hidden. It now falls back to the start time.
- service requests validate the HTTP status and tolerate an empty body: a 4xx
was treated as success and a 204 as failure.
- creating a service with no id in the response no longer reports success and
navigates to a service that does not exist.
- dispatching LoadService from build() looped forever on failure; the three
detail screens now load once and offer a retry.
Ratings:
- both sides read userScored, so only one of the two could ever rate. The
client side now reads professionalScored.
- the screen closed before the request finished, killing the provider mid
flight while addComment swallowed every error. It now waits for confirmation.
- score/reputation parsing tolerates integers and numeric strings instead of
emptying the review list.
Also: guarded map lookups in ScoreBloc, a nullable name in the search list,
and error states with retry where a failure used to shimmer forever.
Verified against the backend: `accepted` is the status the API expects, so the
suspected spelling bug was a false alarm and was left alone.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
8c6e2ae024
commit
389f876cfa
@@ -21,12 +21,16 @@ class CommentEntity extends Equatable {
|
||||
|
||||
static CommentEntity fromDocument(Map<String, dynamic> doc) {
|
||||
return CommentEntity(
|
||||
authorId: doc['author_id'] as String,
|
||||
destinationId: doc['destination_id'] as String,
|
||||
serviceId: doc['service_id'] as String,
|
||||
content: doc['content'] as String,
|
||||
score: doc['score'] as double,
|
||||
isFromUser: doc['is_from_user'] as bool,
|
||||
// Tolerant on purpose: a whole-number score arrives as `5`, and
|
||||
// Postgres numerics can arrive as strings. Hard casts here emptied the
|
||||
// whole review list, which then read as "no reviews yet".
|
||||
authorId: doc['author_id']?.toString() ?? '',
|
||||
destinationId: doc['destination_id']?.toString() ?? '',
|
||||
serviceId: doc['service_id']?.toString() ?? '',
|
||||
content: doc['content']?.toString() ?? '',
|
||||
score: double.tryParse(doc['score']?.toString() ?? '') ?? 0.0,
|
||||
isFromUser: doc['is_from_user'] == true ||
|
||||
doc['is_from_user']?.toString() == 'true',
|
||||
createdAt: doc['created_at']?.toString() ?? DateTime.now().toIso8601String(),
|
||||
);
|
||||
}
|
||||
|
||||
@@ -23,10 +23,12 @@ class ReputationEntity extends Equatable {
|
||||
final averagePro = doc['average_pro'] ?? 0.0;
|
||||
|
||||
return ReputationEntity(
|
||||
total: int.parse(total.toString()),
|
||||
average: double.parse(average.toString()),
|
||||
totalPro: int.parse(totalPro.toString()),
|
||||
averagePro: double.parse(averagePro.toString()),
|
||||
// COUNT can come back as "5.0000"; parse as double then truncate so a
|
||||
// reputation of 0.0 never gets shown as if it were real.
|
||||
total: (double.tryParse(total.toString()) ?? 0).toInt(),
|
||||
average: double.tryParse(average.toString()) ?? 0.0,
|
||||
totalPro: (double.tryParse(totalPro.toString()) ?? 0).toInt(),
|
||||
averagePro: double.tryParse(averagePro.toString()) ?? 0.0,
|
||||
);
|
||||
}
|
||||
|
||||
|
||||
@@ -81,19 +81,29 @@ class ApiScoreRepository {
|
||||
return raw.map((e) => CommentEntity.fromDocument(e as Map<String, dynamic>)).toList();
|
||||
}
|
||||
|
||||
/// Throws when the rating could not be stored.
|
||||
///
|
||||
/// This used to swallow every error in an empty catch, so a lost rating was
|
||||
/// indistinguishable from a saved one — for the user *and* for us.
|
||||
Future<void> addComment(CommentEntity comment) async {
|
||||
final res = await http
|
||||
.post(
|
||||
Uri.parse('$_base/comments'),
|
||||
headers: await _headers(),
|
||||
body: jsonEncode({
|
||||
'destination_id': comment.destinationId,
|
||||
'service_id': comment.serviceId,
|
||||
'content': comment.content,
|
||||
'score': comment.score,
|
||||
'is_from_user': comment.isFromUser,
|
||||
}),
|
||||
)
|
||||
.timeout(_kHttpTimeout);
|
||||
if (res.statusCode >= 400) {
|
||||
throw Exception('No se pudo guardar la calificación (${res.statusCode})');
|
||||
}
|
||||
// Refreshing reputation is a nicety; never fail the rating over it.
|
||||
try {
|
||||
await http.post(
|
||||
Uri.parse('$_base/comments'),
|
||||
headers: await _headers(),
|
||||
body: jsonEncode({
|
||||
'destination_id': comment.destinationId,
|
||||
'service_id': comment.serviceId,
|
||||
'content': comment.content,
|
||||
'score': comment.score,
|
||||
'is_from_user': comment.isFromUser,
|
||||
}),
|
||||
).timeout(_kHttpTimeout);
|
||||
await getReputationByUserId(comment.destinationId);
|
||||
} catch (_) {}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user